search

m4b / goblin

An impish, cross-platform binary parsing crate, written in Rust
MIT License
1.17k stars 156 forks source link

pe: parse pkcs7 Content in certificate table #360

Closed baloo closed 1 year ago

RaitoBezarius commented 1 year ago

You should add a mention to the README for this new flag.

m4b commented 1 year ago

Hmmm, I wasn't aware you had plans to add these dependencies to goblin. So in general, this crate is extremely conservative when it comes to dependencies, and none have been added for about 4-5 years, and the ones it does have I'm in control of or will never change, like adding more dependencies (or if it does, i'll just delete the dep, e.g. plain). It's going to take some good convincing why this needs to be in goblin itself, and why the user can't just call this function themselves on the raw bytes. In general, for more sophisticated structures like this, in this crate I've generally sided on the fact that it's not goblin's job to parse this unless it has to. And in this PR I don't see any reason why it has to (e.g., the user can just call this). Anyway, that's the general stance, apologies in advance if that's disappointing :)

baloo commented 1 year ago

This is less of an issue here than it is in #358 I'll reply there

baloo commented 1 year ago

Can implement this in a sub-crate. Let me know if you want to get involved, or retain control over such a subcrate.