m4b / goblin

An impish, cross-platform binary parsing crate, written in Rust
MIT License
1.2k stars 160 forks source link

Fix parsing PE with zero raw_data_size of section #396

Closed ideeockus closed 1 month ago

ideeockus commented 8 months ago
  1. Sometimes I need to parse PE header without parsing DOS header + DOS stub

  2. Seems that finding offset by rva is not implemented correctly and breaks down on some PE files. See #307

m4b commented 1 month ago

@ideeockus just fyi, in the next breaking release 0.10, the pe::Header will have a lifetime parameter, just curious, will this be ok for your usecases? If people need owned versions I was thinking of some ways to allow this, but if it's not readily needed, I won't think too hard about it

m4b commented 1 month ago

ok published in 0.9.2, thanks for your contribution!