m4b / goblin

An impish, cross-platform binary parsing crate, written in Rust
MIT License
1.18k stars 158 forks source link

PE: parse rich header and refactor DOS stub parser #406

Open kkent030315 opened 5 months ago

kkent030315 commented 5 months ago

This PR adds parsing of Rich headers, as someone opened issue #400.

I took the constant bytes in the test code from mthiesen/link-patcher (MIT). If this can potentially be license incompliance, I am happy to make own specimens for testing.

kkent030315 commented 5 months ago

I'm a bit tired, will fix the CI at the rest of today or tomorrow.

m4b commented 4 months ago

@kkent030315 gentle ping; would definitely like to see this go in, but I had requested some changes :)