m4b / goblin

An impish, cross-platform binary parsing crate, written in Rust
MIT License
1.17k stars 156 forks source link

Check if an entry in the TLS callback list is the terminator before trying to load it #413

Open gabrielesvelto opened 1 month ago

gabrielesvelto commented 1 month ago

This fixes issue #412.

gabrielesvelto commented 3 weeks ago

Sure, I'll try to add it.

m4b commented 5 days ago

let me know if you have a test case ready, or if you can modify an existing one that shows this change won't add any regressions, etc. thanks!

gabrielesvelto commented 5 days ago

let me know if you have a test case ready, or if you can modify an existing one that shows this change won't add any regressions, etc. thanks!

Yeah, I'll add a test here and provide a fix for issue #412 too later this year. I've been caught up in other stuff but I'll try to come back to this ASAP.

m4b commented 4 days ago

@gabrielesvelto no worries, just doing some triage this weekend/poking people :)