search

m4b / scroll

Scroll - making scrolling through buffers fun since 2016
MIT License
151 stars 36 forks source link

Add generics support to scroll_derive #68

Closed Systemcluster closed 4 years ago

Systemcluster commented 4 years ago

This adds support for deriving Pread, Pwrite, IOread, IOwrite and SizeWith on generic structs.

m4b commented 4 years ago

Shit was I supposed to merge other first :(

m4b commented 4 years ago

Ok looks like you just have to rebase @Systemcluster according to comments in other; thank you for this btw, this is quite cool!

Systemcluster commented 4 years ago

Rebased, thanks for merging these!

m4b commented 4 years ago

@Systemcluster do you want a new release? I think this is safe for a patch release, since it just adds additional deriving functionality, and shouldn't be able to break anyone?

m4b commented 4 years ago

(Also thanks very much for taking the time to add this functionality, very cool stuff :))

m4b commented 4 years ago

ok scroll derive 0.10.2 is out, so should be able to use this from crates.io now; thanks for the hard work! :)