m4ce / sensu-plugins-docker-checks

A sensu plugin to monitor Docker containers
MIT License
1 stars 0 forks source link

Conflict with official check name #1

Open tgagor opened 7 years ago

tgagor commented 7 years ago

Hi,

I really like your plugin - it allow to check if particular container is running, something that check from official package ( https://github.com/sensu-plugins/sensu-plugins-docker ) do not allow. But they have good metrics plugins.

Problem with your plugin is that your check have the same name like check from official package. I could install official package and then overwrite their check with your, but IMO it's not good idea. Additionally I use Ansible for configuration and there's no --force option to that will allow to install your plugin over official plugin automatically ;/

It's going now to my request - could you rename your check to anything that won't conflict with official check?

m4ce commented 7 years ago

Hi,

hm - I'd rather add the missing features than renaming the plugin. What are you missing from this plugin? Only the metrics?

tgagor commented 7 years ago

Hi,

I started with sensu for infrastructure monitoring and used your check to ensure containers are running. But after some time we extended sensu usage with metrics to create some graphs (influxdb + grafana) and I switched to official plugin because it have metrics. Then I found that their check do not match container names - only number of containers running. IMO it's pointless to use it.

Right now I would like to use official metrics (my grafana config depends on them and for sure I don't want to migrate to new schema, etc). I also want to use your plugin for container checks. But because of filename conflict it's not easy to install both.

I had three possibilities to resolve this problem:

I'm not sure if there is a sense to implement another (another to official) metrics, then maintain them, etc.