joeldn commented 7 years ago

This way there will be no collisions in file names if the same request is made in a short (< 1 ms) amount of time (for instance when running load tests).

codecov-io commented 7 years ago

Codecov Report

Merging #19 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files           1        1           
  Lines          86       86           
  Branches        6        6           
=======================================
  Hits           81       81           
  Misses          5        5

Impacted Files	Coverage Δ
index.js	`94.18% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11b672d...7cad7fa. Read the comment docs.

m4nuC commented 7 years ago

Hi @joeldn, Sorry for the delay. I am hesitant to pull a dependency for what seems to be an edge case. Did you bump into that issue yourself?

joeldn commented 7 years ago

Yeah I was having issues with load testing, so for my use case the filename needs to have some sort of random addition. I get your remark on the extra dependency though. What if I update my PR to use Math.random().toString(16).substring(2) in stead of the UUID package?

m4nuC commented 7 years ago

Sounds good to me. Please update your PR and I will merge that

m4nuC commented 7 years ago

Thanks Joel 👍

m4nuC / async-busboy

Uses uuid in temp file name #19

Codecov Report