search

m4nuC / async-busboy

Promise based multipart form parser for KoaJS
MIT License
167 stars 58 forks source link

Changed writeStream onError handler #33

Closed hyralm closed 6 years ago

hyralm commented 6 years ago

If file stream isn't consumed, the rejected error won't be caught. I got this issue when I tried to upload file with very long name.

codecov-io commented 6 years ago

Codecov Report

Merging #33 into master will decrease coverage by 0.88%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   93.81%   92.92%   -0.89%     
==========================================
  Files           1        1              
  Lines          97       99       +2     
  Branches       11       11              
==========================================
+ Hits           91       92       +1     
- Misses          6        7       +1
Impacted Files Coverage Δ
index.js 92.92% <77.77%> (-0.89%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b99ddc2...433015b. Read the comment docs.

m4nuC commented 6 years ago

Thanks !