search

m4nuC / async-busboy

Promise based multipart form parser for KoaJS
MIT License
167 stars 58 forks source link

Breaks on Node 16 #49

Open fjeddy opened 2 years ago

fjeddy commented 2 years ago

^^ Same thing as #42

Krizz commented 2 years ago

I fixed this issue by removing the cleanup function. https://github.com/Krizz/async-busboy/commit/1a41cf06a575d9038dbc3d2c34ca58f437c90eac

It is a quick fix just to get the upload working for myself and I have not tested it thoroughly. But it might be a good start for someone to come up with a proper fix.

mjasnikovs commented 2 years ago

Meh... Still broken. Please mark the project as deprecated on npm.

amit777 commented 1 year ago

I can confirm that @Krizz fix works for me as well.

winrono commented 1 year ago

still seems to be an issue :confused: in NodeJS 16

amit777 commented 1 year ago

Did the @Krizz fix not work for you?

winrono commented 1 year ago

@amit777 it did. I used his fork as a temporarily solution.

However, would be nice if library itself also has it.

chaitu2chowdary commented 1 year ago

same issue. :(

ardelio commented 5 months ago

I don't think the issue is with async-busboy, but instead Koa.

NodeJS http is closing the request when I would expect it not to. The issue here is, I think, figuring out why NodeJS is issuing the close event, when we are in the depths of our application code 🤔