search

m5stack / M5Core2

M5Core2 Arduino Library
MIT License
265 stars 116 forks source link

AXP192: fix register in SetLDOVoltage() function. #5

Closed felmue closed 4 years ago

felmue commented 4 years ago

Fix for issue: https://github.com/m5stack/M5Core2/issues/4

jesse-schein commented 4 years ago

validated it works well here. The vibration motor is much better when its set at 3.3v

felmue commented 4 years ago

@Hades2001 - any reason you closed this pull-request without merging? Just curious. Thanks.

Hades2001 commented 4 years ago

Thank you very much for your pull-request,I've recently been trying to fix bugs in Core2 and add some features,This problem has been fixed in the new version，The new version will be submitted in the near future.

------------------ 原始邮件 ------------------ 发件人: "felmue"<notifications@github.com>; 发送时间: 2020年9月21日(星期一) 下午4:57 收件人: "m5stack/M5Core2"<M5Core2@noreply.github.com>; 抄送: "有鹿的地方"<1521377294@qq.com>; "Mention"<mention@noreply.github.com>; 主题: Re: [m5stack/M5Core2] AXP192: fix register in SetLDOVoltage() function. (#5)

@Hades2001 - any reason you closed this pull-request without merging? Just curious. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

felmue commented 4 years ago

Hello @Hades2001

ok, thank you for confirming and for working on improving Core2. I appreciate it and I am looking forward to checking out the new features.

Cheers Felix