search

m5stack / M5Core2

M5Core2 Arduino Library
MIT License
263 stars 115 forks source link

GPS unit example uses incorrect GPIOs for RX and TX #75

Closed felmue closed 2 years ago

felmue commented 2 years ago

Hello M5Stack engineers

the GPS unit example for M5Core2 seems to only have been copied verbatim from the M5Stack example except for the include file. Sorry, that is not enough, as M5Stack uses GPIOs 16 and 17 for RX and TX whereas M5Core2 uses GPIOs 13 and 14.

This line ss.begin(GPSBaud); in the example needs to be replaced with ss.begin(GPSBaud, SERIAL_8N1, 13, 14);.

Please also see this thread from the community forum.

Thanks Felix

P.S. I know I could provide a pull-request, but from my experience in the past, PRs are mostly ignored anyways, so I won't bother doing that.

Tinyu-Zhao commented 2 years ago

Thank you for your help, we have corrected this error