minovap
commented
10 months ago I don't know why it was failing, but the same codebase seem to work now.
Closed minovap closed 10 months ago
minovap
commented
10 months ago I don't know why it was failing, but the same codebase seem to work now.
I am running commit 2b18d32 and I get a build fail in ESPhome.
Compiling .pioenvs/m5cores3/src/esphome/components/psram/psram.cpp.o Compiling .pioenvs/m5cores3/src/esphome/components/script/script.cpp.o Compiling .pioenvs/m5cores3/src/esphome/components/socket/bsd_sockets_impl.cpp.o Compiling .pioenvs/m5cores3/src/esphome/components/socket/lwip_raw_tcp_impl.cpp.o In file included from src/esphome/components/m5cores3_display/m5cores3_display.cpp:2: src/esphome/components/m5cores3_display/m5cores3_display.h:9:8: error: 'void esphome::m5cores3_display::M5CoreS3Display::setup()' marked 'override', but does not override void setup() override; ^~~~~ src/esphome/components/m5cores3_display/m5cores3_display.h:10:9: error: 'float esphome::m5cores3_display::M5CoreS3Display::get_setup_priority() const' marked 'override', but does not override float get_setup_priority() const override; ^
~~~~~ src/esphome/components/m5cores3_display/m5cores3_display.h:11:8: error: 'void esphome::m5cores3_display::M5CoreS3Display::dump_config()' marked 'override', but does not override void dump_config() override; ^~~src/esphome/components/m5cores3_display/m5cores3_display.h:18:8: error: 'void esphome::m5cores3_display::M5CoreS3Display::update()' marked 'override', but does not override void update() override; ^~Compiling .pioenvs/m5cores3/src/esphome/components/socket/lwip_sockets_impl.cpp.o Compiling .pioenvs/m5cores3/src/esphome/components/socket/socket.cpp.o Compiling .pioenvs/m5cores3/src/esphome/components/switch/automation.cpp.o Compiling .pioenvs/m5cores3/src/esphome/components/switch/switch.cpp.o Compiling .pioenvs/m5cores3/src/esphome/components/template/switch/template_switch.cpp.o Compiling .pioenvs/m5cores3/src/esphome/components/voice_assistant/voice_assistant.cpp.o Compiling .pioenvs/m5cores3/src/esphome/components/web_server_base/web_server_base.cpp.o *** [.pioenvs/m5cores3/src/esphome/components/m5cores3_display/m5cores3_display.cpp.o] Error 1 ========================= [FAILED] Took 77.50 seconds =========================The full log is here:
logs_cores3_run.txt