m5stack / M5Dial-UserDemo

M5Dial user demo for hardware evaluation.
MIT License
44 stars 16 forks source link

Encoder Ring Not Working After Flashing #8

Closed sayzard closed 7 months ago

sayzard commented 7 months ago

I recently purchased an M5Dial. Everything was working fine until I downloaded the firmware from GitHub, built it, and flashed it onto the device. After the flashing process, the encoder ring stopped responding. The click functionality is still operational, allowing access to the LCD TEST menu, but the rotation of the encoder does not trigger any response.

Could anyone provide guidance on whether there is a specific configuration or setting adjustment needed during the build process to get the encoder ring working again? Any assistance would be greatly appreciated.

Thank you.

moisesfa commented 7 months ago

I have the same problem.The encoder stopped working when flashing the example.

moisesfa commented 7 months ago

The encoder works if you comment these lines in the main file. I still don't know why, but it works.

    // if (!hal.encoder.btn.read())
    // {   
    //     uint16_t time_count = 0;
    //     while (!hal.encoder.btn.read())
    //     {
    //         delay(10);
    //         time_count++;
    //         if ((time_count * 10) > 1000)
    //         {
    //             factory_test_mode = true;
    //             break;
    //         }
    //     }
    // }

Regards

Forairaaaaa commented 7 months ago

Hi, it's a bug from the encoder library, will be fixed soon

Forairaaaaa commented 7 months ago

It should be all ok now

sayzard commented 7 months ago

Thanks for fixing the issue. It works great now!