search

m5stack / M5Stack

M5Stack Arduino Library
MIT License
1.19k stars 424 forks source link

Code and commit quality #261

Closed f4grx closed 2 years ago

f4grx commented 2 years ago

Hello, can you please have more precisions in your commits?

It is extremely hard to get a sense of what you're doing with that kind of commit:

https://github.com/m5stack/M5Stack/pull/260/commits/b71461937823f1fecaa799ad8bd37b3ef962b434

comment is just "a"

This is not a good coding practice.

Thank you.

Tinyu-Zhao commented 2 years ago

I'll write it in more detail