m5stack / M5Stack

M5Stack Arduino Library
MIT License
1.19k stars 425 forks source link

Issues in M5LoRa component #303

Open ManuelFollmann opened 1 year ago

ManuelFollmann commented 1 year ago

Describe the bug

I was switching a project using LoRa files from https://github.com/sandeepmistry/arduino-LoRa to the M5LoRa files. The application was not working and I got it back to work when using the arduino-LoRa files instead. I started to compare both sources and I found at least one issue.

define REG_PKT_SNR_VALUE 0x1b needs to be changed to 0x19. 0x1b is the RSSI value

I will start to analyse if further changes are required to get same functionality

To reproduce

Sending LoRo messages on 433 MHz

Expected behavior

Same functionality is given as implemented in the source of those Lora files https://github.com/sandeepmistry/arduino-LoRa

Screenshots

No response

Environment

Additional context

No response

Issue checklist