search

m5stack / M5StickC-Plus

M5StickCPlus Arduino Library
MIT License
372 stars 89 forks source link

Fixed Get/Set Data->Date #40

Closed whiteneon closed 2 years ago

whiteneon commented 2 years ago

Resolves Open Issue: https://github.com/m5stack/M5StickC-Plus/issues/8#issue-771474989

Tinyu-Zhao commented 2 years ago

Since our functions have to be unified with other libraries as much as possible, I can't accept changes in the naming of functions related to Button, sorry.

I have pushed a new version to correct the typos in the RTC https://github.com/m5stack/M5StickC-Plus/commit/f4f2ef8c3619fed4c430ce6e1f486c5c63f7c09e, thank you for your contribution, and you are welcome to PR for the repository again!

RocketManRC commented 2 years ago

The change to fix typos in RTC.cpp now creates two versions of the method:

void RTC::GetDate(RTC_DateTypeDef* RTC_DateStruct)

This prevents the library from building at least with PlatformIO (the Arduino IDE may ignore this but I did not try it). There should only be one version of this method.