m6w6 / ext-http

Extended HTTP Support
BSD 2-Clause "Simplified" License
79 stars 22 forks source link

tests/gh-issue50.phpt fails with PHP 7.4.0 #100

Closed Whissi closed 4 years ago

Whissi commented 4 years ago
---- EXPECTED OUTPUT
Test
http\Exception\RuntimeException: http\Client::dequeue(): Could not dequeue request while executing callbacks in %sgh-issue50.php:9
Stack trace:
#0 %sgh-issue50.php(9): http\Client->dequeue(Object(http\Client\Request))
#1 [internal function]: {closure}(Object(http\Client), Object(http\Client\Request), 18, 'GET / HTTP/1.1%s...')
#2 %sgh-issue50.php(14): http\Client->send()
#3 {main}
===DONE===
---- ACTUAL OUTPUT
Test
http\Exception\RuntimeException: http\Client::dequeue(): Could not dequeue request while executing callbacks in /var/tmp/portage/dev-php/pecl-http-3.2.3/work/php7.4/tests/gh-issue50.php:9
Stack trace:
#0 /var/tmp/portage/dev-php/pecl-http-3.2.3/work/php7.4/tests/gh-issue50.php(9): http\Client->dequeue()
#1 [internal function]: {closure}()
#2 /var/tmp/portage/dev-php/pecl-http-3.2.3/work/php7.4/tests/gh-issue50.php(14): http\Client->send()
#3 {main}
===DONE===
---- FAILED
m6w6 commented 4 years ago

Thank you for this report. Unfortunately you did not provide enough information to handle this bug, while the tests succeed on travis-ci: https://travis-ci.org/m6w6/ext-http/jobs/618250434

Whissi commented 4 years ago

This test depends on zend.exception_ignore_args = Off whereas I was testing with zend.exception_ignore_args = On. Could you please adjust test suite to enforce correct setting?

Whissi commented 4 years ago

Comment deleted -- I just learned about SKIP_ONLINE_TESTS. :)