search

m6w6 / ext-pq

PostgreSQL client library (libpq) binding
BSD 2-Clause "Simplified" License
39 stars 7 forks source link

fix issue #19: Failed test with PgSQL < 9.3 #33

Closed m6w6 closed 5 years ago

m6w6 commented 5 years ago

If #19 is still a thing, care to give it a test Remi?

codecov[bot] commented 5 years ago

Codecov Report

Merging #33 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   78.57%   78.57%           
=======================================
  Files          18       18           
  Lines        3808     3808           
=======================================
  Hits         2992     2992           
  Misses        816      816
Impacted Files Coverage Δ
src/php_pqres.c 86.6% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0d5115...b71a522. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #33 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   78.57%   78.57%           
=======================================
  Files          18       18           
  Lines        3808     3808           
=======================================
  Hits         2992     2992           
  Misses        816      816
Impacted Files Coverage Δ
src/php_pqres.c 86.6% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0d5115...b71a522. Read the comment docs.

remicollet commented 5 years ago

Thanks, I confirm test suite passes with postgresql 9.2.24 (on RHEL-7.6)