search

m88i / nexus-operator

Sonatype Nexus OSS Kubernetes Operator based on Operator SDK
http://operatorhub.io/operator/nexus-operator-m88i
Apache License 2.0
49 stars 15 forks source link

Rewrite comparator logic #39

Closed LCaparelli closed 4 years ago

LCaparelli commented 4 years ago

Currently the comparator is not using custom comp functions, which leads to changes in Ingress (which doesn't have a default comparator) to be left unaddressed. We could wrap the comparator with a builder to point to our own comp functions, such as in the Kogito Operator.

This also increases our control over this part of the reconcile loop, which can prove to be useful in the long run.

ricardozanini commented 4 years ago

should we fix this for 0.2.0?

LCaparelli commented 4 years ago

Hey @ricardozanini do you still think this is necessary after #55 was resolved by shifting comparison responsibility to the resource managers?

ricardozanini commented 4 years ago

I don't think so. We might close this one. :)