search

m8sec / CrossLinked

LinkedIn enumeration tool to extract valid employee names from an organization through search engine scraping
GNU General Public License v3.0
1.3k stars 183 forks source link

Bugs fix #26

Closed frapava98 closed 1 year ago

frapava98 commented 1 year ago

Fix csv columns naming Fix unique detection in txt file Fix fail msg logging

m8sec commented 1 year ago

Hi @frapava98,

Appreciate the heads up! I ran into the same issue with uppercase names resulting in duplicates 😱 . This has been corrected in the latest push by adding .lower() to the string parser function in search.py.

frapava98 commented 1 year ago

Hi @m8sec, thanks for considering my request and updating the code! In my PR I also fixed the fact that the CSV was created without the names of the columns, which also started with a white space, making the data tricky to access (for example, row['Name'] didn't work, but row[' Name'] yes XD).

m8sec commented 1 year ago

Hi @frapava98

In the current code, the CSV file logger is created in __init__.py:main() and passed to search.py using the logging module's getLogger on line 15. As opposed to passed via variable.

However, I did confirm the CSV headers not being logged and agree about the data being hard to process. Love your changes to logger.py in setup_file_logger() & first_run(). Is there anyway you can modify or resubmit the PR?

m8sec commented 1 year ago

Bug fixes patched in Commit 89484ab & PR #28.