mAAdhaTTah / brookjs

reactive programming tools for well-structured, testable applications
https://mAAdhaTTah.github.io/brookjs/
MIT License
15 stars 1 forks source link

Drop browser field from pkg.json? #262

Closed mAAdhaTTah closed 6 years ago

mAAdhaTTah commented 6 years ago

A default CRA install picks up browser rather than module first. Our umd build in the browser key is "fully bundled" (so it comes with all its own dependencies), which doesn't really work right if you have Kefir as a peerDep. You end up with 2 instances of Kefir (booo!), one in the UMD build and one pulled in directly. The UMD build was intended to allow users to drop brookjs into a script tag and get going with it.

Should we drop browser from pkg.json? It appears "browser" is only for modules with browser-specific differences, so we may be using it incorrectly.

mAAdhaTTah commented 6 years ago

This is a "yes".