search

mCodingLLC / VideosSampleCode

Code from the mCoding sample videos
MIT License
952 stars 198 forks source link

Minor attribution in the getsize method #4

Closed z-a-f closed 2 years ago

z-a-f commented 2 years ago

Giving some love to developers with minor visibility :)

The getsize method is adopted from Wissam Jarjoui (also here). This is just a minor attribution change to show some love to the community.

Note to the project owner: if the code similarities are purely accidental, my apologies -- feel free to discard.

Tests: Not required unless documentation is compiled from docstrings.

mCodingLLC commented 2 years ago

The code is taken from https://stackoverflow.com/questions/449560/how-do-i-determine-the-size-of-an-object-in-python, and it appears to be quite different the one you link. I'm happy to add this link if you update your PR.

z-a-f commented 2 years ago

My bad :) I just have too much free time before the end of the quarter :)

mCodingLLC commented 2 years ago

No worries, good on you for both knowing of another getsize implementation and for trying to support smaller contributors!