search

mDibyo / berkeley-scheduler

https://berkeleyscheduler.com
BSD 2-Clause "Simplified" License
11 stars 3 forks source link

PE Classes show up on final scheduling #35

Closed vyom-kavishwar closed 7 years ago

vyom-kavishwar commented 8 years ago

Even though they don't have exams (attendance based), the scheduler adds them into the finals slots based on the timings, adding more finals than you actually have

mDibyo commented 8 years ago

Thanks for reporting this! Is there a specific list or department of PE classes?

tiffanyqi commented 8 years ago

There are some classes that will not have final exams, but are not listed anywhere currently as to whether or not there will be a final (that info will come out in October). May be good to put in the beginning message as "some of these classes may not have finals" rather than looking for each individual edge case.

mDibyo commented 8 years ago

@tiffanyqi That seems like the right thing to do. Will make the change.

mDibyo commented 7 years ago

@tiffanyqi So turns out, the API provides this information as part of the class information. So, I am just gonna use that in future.

mDibyo commented 7 years ago

This is now resolved in #86.