mI-PIV / app

Mobile Instructional Particle Image Velocimetry (mI-PIV) is an educational Android application that teaches users about fluid mechanics through real-time experiments and curricular modules.
MIT License
8 stars 4 forks source link

Results maximize #342

Closed kp-121 closed 2 years ago

kp-121 commented 2 years ago
jack-elliott commented 2 years ago

So rotating the screen at the results page causes a crash. While the above issues may be improvement, the crash specifically should be dealt with as a bug imo.

kp-121 commented 2 years ago

I'm might have fixed this. @jack-elliott could you check this and make sure. I'll watch the crash reports.

jack-elliott commented 2 years ago

this is now working

On Wed, Aug 31, 2022 at 2:49 PM Kris Price @.***> wrote:

I'm might have fixed this. @jack-elliott https://github.com/jack-elliott could you check this and make sure. I'll watch the crash reports.

— Reply to this email directly, view it on GitHub https://github.com/mI-PIV/app/issues/342#issuecomment-1233407116, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASRTNWIVC32RXRCTOJOMYVDV37AOVANCNFSM55IL3SPA . You are receiving this because you were mentioned.Message ID: @.***>

jack-elliott commented 2 years ago

However, when the phone is rotated, it re-displays the save location dialogue and seems to reset some parameters (vector scale included)

On Wed, Aug 31, 2022 at 4:29 PM Jack Elliott @.***> wrote:

this is now working

On Wed, Aug 31, 2022 at 2:49 PM Kris Price @.***> wrote:

I'm might have fixed this. @jack-elliott https://github.com/jack-elliott could you check this and make sure. I'll watch the crash reports.

— Reply to this email directly, view it on GitHub https://github.com/mI-PIV/app/issues/342#issuecomment-1233407116, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASRTNWIVC32RXRCTOJOMYVDV37AOVANCNFSM55IL3SPA . You are receiving this because you were mentioned.Message ID: @.***>

kp-121 commented 2 years ago

I noticed that as well. I'll make a ticket.