search

mKaloer / powerline_mem_segment

Apache License 2.0
18 stars 7 forks source link

Use Powerline Segment class instead of the old Powerline function interface #7

Open madhurjain2095 opened 4 years ago

madhurjain2095 commented 4 years ago
  1. Combined the two functions mem_usage and mem_usage_percent into a single class MemUsageSegment and exposed a single object of that class.
  2. Added documentation on how the parameters are used.
  3. Updated README.md to reflect the new refactored implementation.
madhurjain2095 commented 4 years ago

Inspired from powerline-gitstatus and powerline-docker (both of which I use)

mKaloer commented 4 years ago

Hi, thanks for this - looks good to me. However, I'm wondering what the advantage of this approach is (besides the code maybe being a bit cleaner). Since this is a breaking change, I'm not going to merge it before I'm sure it's actually worth a breaking change :)

madhurjain2095 commented 4 years ago

Hey, apologies for the delay in response (was busy with my courses)

Yeah, IMO I think it's better to move forward with the new design as per Powerline documents, and as such, reduce the technical debt that occurs with staying with the old version.

Other than that, I don't think there's any other clear advantage with this pull request.