search

mLewisLogic / saddle

A Ruby framework for service clients
MIT License
37 stars 4 forks source link

Removing Airbrake from Rails logger middleware #13

Closed conarro closed 10 years ago

conarro commented 10 years ago

Removing Airbrake require from Rails Logger middleware to avoid errors when Airbrake is not defined.

mLewisLogic commented 10 years ago

Thanks!

mLewisLogic commented 10 years ago

0.0.53 now has this change. https://rubygems.org/gems/saddle/versions/0.0.53

conarro commented 10 years ago

Great, thanks! I did notice that 1.8.7 has been removed from Travis...any reason why? I added support for it as we use it in one of our environments so would need that support in order to update the version.

mLewisLogic commented 10 years ago

I'm gonna stop the official support because Travis was having issues with it, but I'm still running tests locally and they're passing. Actually, even just fixed a 1.8.7 specific spec failure.

mLewisLogic commented 10 years ago

See this guy: https://travis-ci.org/mLewisLogic/saddle/jobs/25093440

mLewisLogic commented 10 years ago

If you can get a fix on those failures, I'll be happy to merge them back in and re-enable Travis on it. I just don't want to invest the time in fixing 1.8.7 only issues. If it's important for your needs, more than happy to keep the CI running to ensure we don't get any regressions.