search

mLewisLogic / saddle

A Ruby framework for service clients
MIT License
37 stars 4 forks source link

Make Saddle work with Faraday 0.9+. #14

Closed BMorearty closed 9 years ago

BMorearty commented 9 years ago

To: @mLewisLogic

What? Why?

Upgrade Saddle to work with Faraday 0.9+.

These changes are not backward-compatible with Faraday 0.8.x.

I had to monkeypatch Faraday::Request because Faraday 0.9 validates the keys used in the request options, but Saddle passes additional options.

How was this tested?

Ran the specs and ran the saddle-example specs.

Version note

I bumped the version to 0.1.0.rc1. Once this is tested some more, I can use 0.1.0. The 0.1.xx versions will be compatible with Faraday 0.9.x. [Update: removed the .rc1 from the version after more testing].

The 0.0.xx versions can continue to be used for updates that have to remain compatible with Faraday 0.8.x.

BMorearty commented 9 years ago

Ignoring annoying houndbot.

BMorearty commented 9 years ago

@mLewisLogic I made the changes you suggested.

BMorearty commented 9 years ago

@mLewisLogic I made some updates to the readme. See 8fdd8a4.

mLewisLogic commented 9 years ago

:+1:

mLewisLogic commented 9 years ago

K, built and pushed the gem.