search

mLewisLogic / saddle

A Ruby framework for service clients
MIT License
37 stars 4 forks source link

Loose `faraday` constraint to allow for `0.x` and `1.x` #21

Closed santiagorodriguez96 closed 6 months ago

santiagorodriguez96 commented 6 months ago

Motivation / Background

This PR adds compatibility with fadaray v0.x and v1.x. This is of interest given that faraday v1.10.3 supports Ruby 3 too so we don't need to force users of the gem to upgrade to faraday v2 – which could be a complex upgrade.

Detail

This PR checks the Faraday version in order to conditionally require other dependencies and include pieces of code that are needed in versions of faraday < 2.

It also adds appraisal definitions for versions 0.x, 1.x and 2.x of faraday so that we also test against them.

mLewisLogic commented 6 months ago

Most excellent. Thanks for doing the work here. LGTM. Let me know when you want a final review and merge.

santiagorodriguez96 commented 6 months ago

Most excellent. Thanks for doing the work here. LGTM. Let me know when you want a final review and merge.

Thanks! It's ready for review so feel free to leave comments or approve it 🙂

mLewisLogic commented 6 months ago

Thanks for the effort. I pushed a new gem version: https://rubygems.org/gems/saddle/versions/0.2.2