search

mParticle / mparticle-android-sdk

mParticle SDK for Android apps
http://www.mparticle.com
Other
58 stars 62 forks source link

fix: Remove recursion from the method and add default URL generation. #501

Closed Mansi-mParticle closed 2 months ago

Mansi-mParticle commented 3 months ago

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml

  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

    Summary

    • Remove recursion from the method and add a feature to create a default URL. This includes a default URL for HMAC signatures when domain mapping is used.

    Testing Plan

    • [x] Was this tested locally? If not, explain why.
    • Tested with sample application and executed unit test case

    Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

rmi22186 commented 2 months ago

I would do a squash and merge into a single commit into the other feature branch.