mParticle / mparticle-apple-sdk

mParticle Apple SDK
Apache License 2.0
45 stars 66 forks source link

test: Fix unit tests and add isLaunch test #241

Closed einsteinx2 closed 9 months ago

einsteinx2 commented 9 months ago

Summary

I found that there was an MPBackgroundController unit test called testPreviousForegroundTime that was failing only on Github due to the way it was implemented. While investigating that, I found that I had the isLaunch boolean backwards, and it should also have its own unit test.

I also noticed that some tests were disabled for tvOS when there's no reason for that as the behavior should be the same, so I enabled them.

I also fixed how some of the other tests were implemented regarding messageQueue threading.

Testing Plan

mparticle-automation commented 9 months ago

:tada: This PR is included in version 8.17.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: