mParticle / mparticle-apple-sdk

mParticle Apple SDK
Apache License 2.0
45 stars 66 forks source link

fix: Prevent Database Growth When ATT Status Denied #247

Open BrandonStalnaker opened 7 months ago

BrandonStalnaker commented 7 months ago

Summary

BrandonStalnaker commented 7 months ago

@einsteinx2 So the only issue I could find should identity.mparticle.com or nativesdks.mparticle.com be blocked is that the database could grow excessively large depending on what HTTP response a blocked URL returns. This change prevents that issue by blocking events from being saved to the DB. Currently, I'm only blocking save to the database when ATT Status is denied so that users not utilizing ATT Status won't see any change.

Personally I'm worried this change might be excessively cautious since events are already blocked at the Mparticle server level based on ATT status but it is what the ticket asked for and we can't be sure what HTTP response apple will give when blocking urls.