mParticle / mparticle-apple-sdk

mParticle Apple SDK
Apache License 2.0
46 stars 66 forks source link

ci: Increase timeout on unit test expectations #264

Closed einsteinx2 closed 7 months ago

einsteinx2 commented 7 months ago

Summary

After doing some digging it appears that the errors and other failed tests related to the kit registry were a red herring. What it appears was happening was that on a slow CI runner if one of the tests with chained calls to dispatch_after would time out, it would move on to the next tests but then a few seconds later it would finish which interfered with the data of other tests. The timing was set pretty tight, or rather plenty of time on a fast MacBook Pro, but tight on a slow CI runner. I've increased all timeouts to 15 seconds, which should be more than enough time for all runners to complete.

Testing Plan

mparticle-automation commented 7 months ago

:tada: This PR is included in version 8.21.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: