feat: Add Option to Disable Certificate Pinning - Githubissues

mParticle / mparticle-apple-sdk

mParticle Apple SDK

Apache License 2.0

45 stars 66 forks source link

feat: Add Option to Disable Certificate Pinning #282

Closed BrandonStalnaker closed 2 months ago

BrandonStalnaker commented 2 months ago

Summary

Added an option to disable certificate pinning, even in production.

Testing Plan
Tested in sample app First Fresh app in development

Screenshot 2024-06-25 at 1 11 40 PM

Second sabotaged certs

Screenshot 2024-06-25 at 1 12 38 PM

Third used existing disabled in development to successfully upload

Screenshot 2024-06-25 at 1 13 23 PM

Screenshot 2024-06-25 at 1 13 53 PM

Fourth switched to Production to confirm it failed with bad certs as expected

Screenshot 2024-06-25 at 1 15 37 PM

Fifth tested change by enabling 'disabledPinning' in production

Screenshot 2024-06-25 at 1 16 15 PM

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Closes https://go.mparticle.com/work/SQDSDKS-6408

mparticle-automation commented 2 months ago

:tada: This PR is included in version 8.25.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: