search

mParticle / mparticle-apple-sdk

mParticle Apple SDK
Apache License 2.0
45 stars 66 forks source link

AppsFlyer is not getting currency for commerce events #56

Closed alexandra-mikh closed 6 years ago

alexandra-mikh commented 6 years ago

Hello, Original issue we are facing is that currency property which is passed to mParticle is not sent to AppsFlyer for commerce events. Checking out the mparticle-apple-sdk it turns out that at some point the property is lost while copying MPCommerceEvent inside mparticle sdk. __block MPCommerceEvent *forwardCommerceEvent = [commerceEvent copy]; Checking out the MPCommerceEvent NSCopying protocol implementation, you can see that currency property is not being copied, which later is affecting AppsFlyer event setup if (commerceEvent.currency) { values[AFEventParamCurrency] = commerceEvent.currency; } I'm not sure if it was done for a reason though. screen shot 2017-11-20 at 15 01 55

samdozor commented 6 years ago

Hi @alexandra-mikh this fix has been released in SDK version 6.15.18. Thanks for your patience!

alexandra-mikh commented 6 years ago

Hi Sam,

Thanks for cooperation and letting us know.

Kind regards, Alexandra.

On 13 Dec 2017, at 21:00, Sam Dozor notifications@github.com wrote:

Hi @alexandra-mikh https://github.com/alexandra-mikh this fix has been released in SDK version 6.15.18. Thanks for your patience!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mParticle/mparticle-apple-sdk/issues/56#issuecomment-351520517, or mute the thread https://github.com/notifications/unsubscribe-auth/AFRXHsXiZJFIscjlwm6WtV_LMJj-pVPGks5tADrkgaJpZM4QkffE.