willpassidomo
commented
4 years ago @samdozor I'm still trying to figure out why the test step is still failing. It's working locally, but I think it might be a dependency version issue(?)
Closed willpassidomo closed 4 years ago
willpassidomo
commented
4 years ago @samdozor I'm still trying to figure out why the test step is still failing. It's working locally, but I think it might be a dependency version issue(?)
willpassidomo
commented
4 years ago @samdozor found a couple things I missed. Hold off on giving this another round for a little bit :)
Summary
This PR now contains everything for v1.0
The big bulk of this work was making all the event classes inherit from BaseEvent, and removing the redundant methods, and adding the EventQueueing
The original API had a weird way of initializing EventsApi, so I refactored it to be ~more like Java Server Events.~ direct constructor call
Readme added with dotnet code samples
Some general cleanup just to remove redundant code
Added PR Template
Added EventQueuing
Added Logger interface and handler
API Samples in the README
Testing Plan
Added a couple unit tests for the EventQueue, in addition to the tons of generated tests that came with it. The generated Unit tests definitely need to be cleaned up, but it's tedious and low-impact enough that it doesn't need to be included here
Master Issue
Closes https://go.mparticle.com/work/50622