search

mProjectsCode / obsidian-media-db-plugin

A plugin that can query multiple APIs for movies, series, anime, games, music and wiki articles, and import them into your vault.
GNU General Public License v3.0
250 stars 30 forks source link

Movie OMDB - Pagination - missing results #144

Open tbonnard opened 5 months ago

tbonnard commented 5 months ago

Describe the bug it seems that pagination is not taking into account for the OMDB API. Example, when you search on "Seven", you only get a few results in the api but if you add the pagination, you get the next results. Example: https://www.omdbapi.com/?s=Seven&apikey=[your_Api_Key]&page=4

To Reproduce Search for Seven: you will only see a few results Go on the url with your API Key and add &page=2 ... you will see the other results (for sure, depending on the search, there might be a lot of pages).

Expected behavior Either a scroll or a pagination could be helpful because right now, some movies are missing.

Screenshots

Occurs on Tested on Windows. No idea for the others but I guess the behaviour is the same.

Plugin version 0.6.0

Additional context Thank you for your help!

mProjectsCode commented 4 months ago

The API does not offer a way to increase page size. Adding pagination to the search results in the plugin sounds like a lot of work. So this is not something I am going to tackle anytime soon, except if someone comes up with a good idea how to tackle this.