search

mProjectsCode / obsidian-media-db-plugin

A plugin that can query multiple APIs for movies, series, anime, games, music and wiki articles, and import them into your vault.
GNU General Public License v3.0
255 stars 31 forks source link

add "only required quotation marks" setting #24

Closed GarDrastic closed 2 years ago

GarDrastic commented 2 years ago

Is your feature request related to a problem? Please describe. I've ran into an interaction issue with the Dataview and DB Folder plugins, noticing that they don't seem to properly read the metadata fields from Media DB generated notes. Outright stripping every " from the YAML and those plugins properly read the fields.

Whatever's happening here seems connected to the quotation marks being present, but not necessarily directly--a field that doesn't use them for numeric values was also not being read. Ex., setting "personalRating: 5" did not read the 5. It was read after stripping out all other " from fields.

Describe the solution you'd like I think this might actually be an issue with dataview/db folder's side, because certainly the metadata looks valid as-is! But a toggle setting to populate the metadata without quote marks and leaving everything else as is would resolve--I've just been manually ctrl-H, replace " with nothing after generating.

Alternately could well be an issue between keyboard and chair as they say! And I'm still testing different things to try to see what specifically triggers it.

Additional context Add any other context or screenshots about the feature request here.

mProjectsCode commented 2 years ago

I can not reproduce this.

I tried the Database folder plugin and got it working. But I noticed, that after creating a column I had to reopen the db-folder note for it to load the data. image

I also have been using dataview for an overview myself and it also works. image

And here the metadata of one of the notes for good measure. image

mProjectsCode commented 2 years ago

But I can implement a setting to only put quotation marks where it is necessary.

Thanks for reporting @GarDrastic and I hope I could help.

GarDrastic commented 2 years ago

And now I can't reproduce it. My theory is I had the new property-remapping syntax subtly mangled -- because in my own testing I removed the remappings I had for movies, and adjusted basic dataview table accordingly, and it worked. Then I added the property remappings back in, readjusted table...and it worked as it should.

My theory is I had some syntax issue either in dataview and/or property remapping configuration. Either way, confident to boil it down to issue between my keyboard and chair! :) Sorry for the premature submission here, and thanks for the plugin!

mProjectsCode commented 2 years ago

I am gonna reopen this so I remember to do this

But I can implement a setting to only put quotation marks where it is necessary.

Also, I am eager to hear any feedback on the property remapping system.

PaperOrb commented 2 years ago

Just noticed this issue. I actually reported this issue on the DB folder plugin and attached the files that caused the issue. It'd be interesting to see if someone here could download the files and try to reproduce the issue.