search

mProjectsCode / obsidian-media-db-plugin

A plugin that can query multiple APIs for movies, series, anime, games, music and wiki articles, and import them into your vault.
GNU General Public License v3.0
255 stars 31 forks source link

Preview modal #59

Closed AB1908 closed 2 years ago

AB1908 commented 2 years ago

Implements #53

AB1908 commented 2 years ago

VSCode has different formatting styles. What should I use to avoid changing whitespaces? Do we want to use something like prettier?

mProjectsCode commented 2 years ago

Do we want to use something like prettier?

Never worked with that, but I can try setting it up I have been using the webstorm formatting up until now

AB1908 commented 2 years ago

Ah shite I screwed up the merge

AB1908 commented 2 years ago

Lmfao I broke it. I'll spend some time cleaning it up.

AB1908 commented 2 years ago

Ok looks like it works. I really wish I knew how to write tests for these lol.

mProjectsCode commented 2 years ago

@AB1908 if you want you can look over this again to see if I broke something

AB1908 commented 2 years ago

I think it looks good. I forgot to pull in your changes earlier and half baked my merge. I'll try and pull this down to test locally.

AB1908 commented 2 years ago

There were some modal closing problems. I'll push a fix later this week hopefully.