search

mProjectsCode / obsidian-media-db-plugin

A plugin that can query multiple APIs for movies, series, anime, games, music and wiki articles, and import them into your vault.
GNU General Public License v3.0
255 stars 31 forks source link

MAL Manga Support Through Second Jikan #99

Closed PhantomOffKanagawa closed 1 year ago

PhantomOffKanagawa commented 1 year ago

A few quick and basic changes I made for a possible way to add manga support through essentially copy-pasting the anime API with Jikan and changing relevant lines as the Jikan API for manga is a one-word difference. Did my best to follow exactly how the MALAPI was setup to make it as consistent as possible and has been working for me through my quick run through of using it on my own.

The only change unrelated to adding manga support was the .gitignore change as it allowed me to ignore built js files when committing so obviously not a feature important piece. I am also not completely sure how some of the typeMappings work but as they seem to be working to my view as the sub-type changes to the relevant type and show correctly in the search.

I wanted to posit this as a possible new feature as it was something I wanted and realized this was the best way to add it as it didn't exist already. I'm new to GitHub collaboration so sorry for any etiquette missteps.

mProjectsCode commented 1 year ago

Thanks for the PR. I am currently quite busy, but I will try to review the PR before the weekend.

mProjectsCode commented 1 year ago

It would also be good to update the readme to reflect the changes made in this PR.

PhantomOffKanagawa commented 1 year ago

Sorry for the slow turnaround. Removed comment, fixed formatting, updated README.md and synced with latest version. It should be all good to go.

mProjectsCode commented 1 year ago

LGTM