mPyKen / ScreenAreaShare

Share selected area of the screen in applications that do not support this, e.g. Teams.
MIT License
148 stars 19 forks source link

Cpu Usage , no framerate limiter #15

Closed 25pinjo15 closed 3 months ago

25pinjo15 commented 10 months ago

Really a nice tool to use ! , But an parameter to add like max fps 60, 30 , 15 would be nice , while sharing code it would prevent fan to ramp up , just need 15 fps when sharing visual studio .

mPyKen commented 10 months ago

thanks! right, that would be a nice addition. do you know if electron provides a simple parameter to limit frame rate by any chance? i will see if i can find the time to look into this:)

25pinjo15 commented 10 months ago

sadly no :(

25pinjo15 commented 10 months ago

But I did clone the repo and tried some stuff , still no luck but you will know if I found something

mPyKen commented 9 months ago

memo: https://stackoverflow.com/questions/70142727/how-to-limit-frame-rate-when-using-getusermedia-with-desktopcapturer-source https://github.com/search?q=repo%3Aelectron%2Felectron+maxFrameRate&type=issues

25pinjo15 commented 9 months ago

just tried that :

video: {
      mandatory: {
        chromeMediaSource: "desktop",
        chromeMediaSourceId: source.id,
        minWidth: display.bounds.width,
        minHeight: display.bounds.height,
        maxFrameRate: 5
      },

    },

and it work ! . I did try before maxfps , fps , ect ect XD

25pinjo15 commented 9 months ago

I made a build with a 15 fps limit . really slow down the fan on my laptop . An i7 in a 13 inch does make some heat XD

mPyKen commented 9 months ago

awesome! i will add a command line option in the next release:)