mRs- / HexColors

HexColors is an extension for UIColor and NSColor to support for creating colors from a hex strings
MIT License
457 stars 102 forks source link

Fixed hex variable bugs #42

Closed cemaleker closed 7 years ago

cemaleker commented 7 years ago

Hex variable was returning wrong hex color values.

First error was a typo where r byte istead of b byte. Second error was about string formatter where color with alpha != 1 returning a six byte hex color value.

Also improved tests.

codecov-io commented 7 years ago

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #42   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         159    175   +16     
=====================================
+ Hits          159    175   +16
Impacted Files Coverage Δ
HexColors-iOSTests/HexColors_iOSTests.swift 100% <100%> (ø) :white_check_mark:
Sources/HexColors.swift 100% <100%> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d959da...4fd0bf0. Read the comment docs.

mRs- commented 7 years ago

Awesome, thanks for this spot :)

mRs- commented 7 years ago

New Pod Version is published :) Happy Usage