search

mWater / mwater-forms

Forms controls for mWater
GNU Lesser General Public License v3.0
3 stars 5 forks source link

Issue131 #150

Closed daxfohl closed 8 years ago

daxfohl commented 8 years ago

@grassick Here's a quick update. Gotta run and get the kid but I'm hoping the code is self-explanatory. Sorry about the whitespace changes. I'll figure out how to prevent those in my editor.

daxfohl commented 8 years ago

@grassick A few questions:

  1. Do you want me to redo this in a new branch, without the whitespace changes?
  2. There are no unit tests here. Making them would require creating a wrapper class for setInterval / clearInterval / getTime, and doing DI. Do you think it's worth the extra level of additional abstraction?
  3. designSchema.coffee isn't updated. I'm pretty sure I see the pattern and what needs to be done, but would like to understand what it does.
grassick commented 8 years ago

Hi Dax,

Yes please on the redo without whitespace changes if it's not too much trouble. As for unit tests, you can use sinon which let's you take over the clock and move it ahead fixed amounts with no DI. We have unit tests for all other answers, so probably a good idea. But keep it simple and minimal. More just a smoke-check.

designSchema is a JSON-schema validation for the form design that is run on the server to make sure no invalid forms are submitted.

Let me know when you have the whitespace changes done and we'll have another look at the PR?