mWater / mwater-forms

Forms controls for mWater
GNU Lesser General Public License v3.0
3 stars 5 forks source link

Not all parameters applying when exporting as PDF #241

Open Autio opened 3 years ago

Autio commented 3 years ago

Examples here: https://share.mwater.co/v3/dashboard_link/8825f8017d1f472bbcf9203631d09b5d?share=e9f165a349b64c978e269767b563a864

I also notice PDF export generation can take a fairly long time.

Side note on pivot table cell backgrounds: Is there any simple way to switch the value in a cell that has a very dark background to be white or at least bright instead? Now black text gets lost in dark blue for example.

broncha commented 3 years ago

I have a fix for the text color, where it switches between white and black text for dark and light background colors resp. But the layers thing is a bit more involved.

Basically, the layer toggling is client-side and scoped to the particular map widget and the server is unaware of it. The example contains one map widget, but a dashboard can contain multiple maps, so what we will need to do is to pass all visible layers of all the maps in the dashboard to the server, which will toggle the respective layers while generating PDF.

That is, keep a record of all the visible layers in top-level in dashboard, and pass that to the server for PDF generation

grassick commented 3 years ago

That's going to add quite a bit more complexity to pull the layer selection up to the top level, no? Let's talk about this one more before executing it.

broncha commented 3 years ago

number 1 fixed in https://github.com/mWater/mwater-common/commit/e037bb8bece57d6bac4641e5f78c74d7351a1ff7

broncha commented 3 years ago

color contrast in pivot table cells also done