Closed broncha closed 1 year ago
There is some complexity around aggregate columns that isn't being taken care of. If I:
I get:
Also, it seems to default the backgroundColorAxis to the textAxis, but then doesn't keep them in sync thereafter. But there's no way to edit the expression of the backgroundColorAxis!
Maybe the two axes should be independent? @Autio ? That is, you can color by something that isn't the same expression as the textAxis. This would get rid of the need for showExpr
Also, note that the textAxis is really just using the expression inside the axis, not the entire axis, for weird historical reasons.
The aggrNeed: "required"
in backgroundColorAxis is going to cause you trouble, as it doesn't always need to be aggregate. But if it is, the table compiler should take it into account and add groupings to all other fields.
@grassick I removed showExpr in AxisComponent, fixed the grouping in background color axis query. What do you suggest for aggrNeed? I have removed that also for now. And color axis is no longer dependant on the textAxis
This is great @broncha ! I added aggrNeed: "optional" and it works perfectly. Merging it in!
@grassick I implemented this for each column, adding a separate
backgroundColorAxis
which includes the expression from textAxis and only xform and colormap from thebackgroundColorAxis
is used. AddedshowExpr
toAxisComponent
as expression would be duplicated for the column!@Autio here is how the implementation looks.