search

ma1uta / ma1sd

Federated Matrix Identity Server (formerly fork of kamax/mxisd)
GNU Affero General Public License v3.0
167 stars 56 forks source link

Load DNS overwrite config on startup and remove duplicates from identity store before email notifications #11

Closed NullIsNot0 closed 4 years ago

NullIsNot0 commented 4 years ago

I recently noticed that DNS overwrite does not happen. There are messages in logs: "No DNS overwrite for ", but I definitely have configured DNS overwrithng. I think it's because DNS overwriting config is not loaded when ma1sd starts up. Documented here: https://github.com/ma1uta/ma1sd/blob/master/docs/features/authentication.md#dns-overwrite and here: https://github.com/ma1uta/ma1sd/blob/master/docs/features/directory.md#dns-overwrite

NullIsNot0 commented 4 years ago

Sorry, I have committed another commit to my repo's master branch. I don't know how to separate it into another pull request. The description for the second pull request is: I use LDAP for user store. I have set up "mail" and "otherMailbox" as threepid email attributes. When people get invited to rooms, they receive 2 (sometimes 3) invitation e-mails if they have the same e-mail address in LDAP "mail" and "otherMailbox" fields. I think it's a good idea to check identity store for duplicates before sending invitation e-mails.

ma1uta commented 4 years ago

Thanks for PR!