ma6254 / FictionDown

小说下载|小说爬取|起点|笔趣阁|导出Markdown|导出txt|转换epub|广告过滤|自动校对
GNU General Public License v3.0
709 stars 140 forks source link

update dep version #3

Closed daixiang0 closed 5 years ago

daixiang0 commented 5 years ago

Signed-off-by: Xiang Dai 764524258@qq.com

daixiang0 commented 5 years ago

Fix #1

ma6254 commented 5 years ago

in the Gopkg.lock line 1

# This file is autogenerated, do not edit; changes may be undone by the next 'dep ensure'.

it's my fault maybe should add Gopkg.lockandvendor/ to .gitignore and use dep ensure generate it

daixiang0 commented 5 years ago

Gopkg.lock and vendor should not be ignored as i saw many go projects do the same. After update and re-generate lock file, can be solved.

ma6254 commented 5 years ago

I also know that most projects do this (commit vendor and GoPkg.lock) but look that

dep/FAQ.md

Should I commit my vendor directory?

It's up to you:

Pros

Cons

https://www.gitignore.io/api/go

# Created by https://www.gitignore.io/api/go
# Edit at https://www.gitignore.io/?templates=go

### Go ###
# Binaries for programs and plugins
*.exe
*.exe~
*.dll
*.so
*.dylib

# Test binary, built with `go test -c`
*.test

# Output of the go coverage tool, specifically when used with LiteIDE
*.out

### Go Patch ###
/vendor/
/Godeps/

# End of https://www.gitignore.io/api/go
ma6254 commented 5 years ago

Maybe I should abandon godep and embrace gomod or vgo

daixiang0 commented 5 years ago

switch to gomod should be better, godep seems gradually transferred to gomod.

daixiang0 commented 5 years ago

For now, keep godep work still make sense.