search

maaaaz / androwarn

Yet another static code analyzer for malicious Android applications
GNU Lesser General Public License v3.0
473 stars 159 forks source link

Remove shebang #26

Open fabaff opened 4 years ago

fabaff commented 4 years ago

Please remove the shebang from all files which don't need it.

For the Fedora package I have to:

sed -i -e '/^#!\//, 1d' androwarn/{__init__.py,androwarn.py,warn/*/*.py,warn/*/*/*.py}
maaaaz commented 4 years ago

Hello @fabaff, Thanks for reporting, but are you sure that a shebang is not needed in androwarn.py ?

It is the entry point, I doubt that it's not a good practice to specify it. And overall, it is not a good practice to specify in each file, even if they are not directly called ?

Cheers.

fabaff commented 4 years ago

Thanks for reporting, but are you sure that a shebang is not needed in androwarn.py ?

Yes, I am. androwarn will contain the shebang as this is the entry point for an installation. But if want to allow users to run it from a checkout then the shebang might be needed in androwarn.py.

And overall, it is not a good practice to specify in each file, even if they are not directly called ?

Those files never get called from the command-line thus not need for shebangs.

maaaaz commented 4 years ago

Thanks for reporting, but are you sure that a shebang is not needed in androwarn.py ?

Yes, I am. androwarn will contain the shebang as this is the entry point for an installation. But if want to allow users to run it from a checkout then the shebang might be needed in androwarn.py.

Ok that's clear, indeed it is expected to also be able to run directly androwarn.py so this will be the only file with a shebang.

And overall, it is not a good practice to specify in each file, even if they are not directly called ?

Those files never get called from the command-line thus not need for shebangs.

Clear