Replace phantomjs by headless Google Chrome

themaks commented 7 years ago

Hi !

phamtomjs' only maintainer has given up on maintaining his software, due to the release of Google Chrome headless browser in version 59

Have you considered to migrate webscreenshot's backend accordingly ?

Thanks in advance !

😛

maaaaz commented 7 years ago

Hello @themaks,

Indeed Chrome headless looks promising but I haven't considered migrating right now because:

It seems that it is difficult to make full page screenshots
The headless mode and --screenshot feature are still recent and it seems that there are some bugs with transparency and background color on websites
There is still no Windows support of Chrome headless: to date webscreenshot+phantomjs can be used on Windows
I don't know how the lazy-rendering, a key feature currently implemented in webscreenshot, could be achieved with Chrome headless

But for sure I'll migrate when things get better.

Cheers.

maaaaz commented 6 years ago

Hello @themaks,

It is now implemented, with the limitations mentioned in the README.

Cheers.

themaks commented 6 years ago

Nice, thanks ! I look forward to test it ! ;)

maaaaz / webscreenshot