search

maael / nook

🐘 A website to track your collections and share custom designs in Animal Crossing: New Horizons!
https://nook.services
15 stars 1 forks source link

Feature Request - i18n #4

Closed drallieiv closed 4 years ago

drallieiv commented 4 years ago

Add localisation to the fish / bugs / fossil names for people playing the game in their own local instead of english.

maael commented 4 years ago

The basics of this has now been done in e225cd09d2597f95217cd46a53f057ae2b9bfe78 and the translations live here in data/translations.

The translations are just a best effort from myself though, they are by no means perfect. I'd love PRs to fix any issues with them.

Here's what it looks like:

Screenshot 2020-04-23 at 11 52 33

There's now a flag next to the search, if you click on it it brings up this modal:

Screenshot 2020-04-23 at 11 53 07

That lets you select a language to view/search by.

At the moment it supports German, Spanish, French, Japanese, and English. It defaults to english, and will save your language choice on your device so it persists between refreshes.

With this I'll close this issue! Any future requests for new languages or fixes to translations can be their own thing.