maahir-garg / pe

0 stars 0 forks source link

Error in the DG #4

Open maahir-garg opened 1 week ago

maahir-garg commented 1 week ago

Screenshot 2024-11-15 at 4.57.18 PM.png

This DG implies that there has to be 1 nickname for a contact which contradicts the UserGuide and functionality where nickname is optional

nus-se-script commented 4 days ago

Team's Response

Since this is a class level diagram written in the developer guide, it should reflect the actual state of classes in the code for the information of future developers, rather than what is revealed to the user.

It is in fact true that each user must have exactly 1 nickname. If the user does not input a nickname or enters a blank field for the nickname, the Contact object will have 1 nickname which is an empty String. This means that a Contact object will always be keeping track of a Nickname object. However, this is not knowledge necessary for the user, and as such we can understand why you may be confused since you did not have access to our code base.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]